This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Actors v8 #1576
Merged
Actors v8 #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Mar 1, 2022
anorth
approved these changes
Mar 1, 2022
gen/gen.go
Outdated
| @@ -119,7 +117,7 @@ func main() { | |||
| // method params and returns | |||
| //paych.ConstructorParams{}, // Aliased from v0 | |||
| paych.UpdateChannelStateParams{}, // Changed in v7 | |||
| paych.SignedVoucher{}, // Changed in v7 | |||
| paych.SignedVoucher{}, // Changed in v7 | |||
There was a problem hiding this comment.
Can you alias these (and below) below onto their v7 definitions?
There was a problem hiding this comment.
Yes, thank you for the catch!
@Stebalien whoah hold up, can we talk about this please? I understand why you say that, but I think there are better alternatives. cc @ZenGround0 @Kubuxu after this lands you probably wanna rebase your FIP work onto v8. |
Consider doing this in a separate PR to keep this one purely mechanical. I didn't notice the new code when scanning. |
jennijuju
added
the
P1
Codecov Report
@@ Coverage Diff @@
## master #1576 +/- ##
======================================
Coverage 69.0% 69.0%
======================================
Files 72 72
Lines 8791 8791
======================================
Hits 6072 6072
Misses 1858 1858
Partials 861 861 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in support of FIP-0031. Although the FIP replaces the primary usecases of this repo with WASM actors, this change is still needed to support:
This PR: