Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make flush match lotus as much as possible #586

Merged
merged 2 commits into from
May 24, 2022

Conversation

Stebalien
Copy link
Member

  1. Reject anything we don't expect.
  2. Properly handle identity cids.

We're also checking the hash function (only allowing blake2b). I could drop that, but it seems like a reasonable sanity check.

1. Reject anything we don't expect.
2. Properly handle identity cids.
@Stebalien Stebalien requested review from Kubuxu and magik6k May 20, 2022 22:41
@Stebalien Stebalien requested a review from arajasek May 23, 2022 16:07
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nitpick in the comment, nothing here looks wrong.

Co-authored-by: Aayush Rajasekaran <[email protected]>
@Stebalien Stebalien enabled auto-merge (squash) May 24, 2022 20:35
@Stebalien Stebalien merged commit 9117d4d into master May 24, 2022
@Stebalien Stebalien deleted the fix/flush-matches-lotus branch May 24, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants