Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run github actions on pull requests from forks #467

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

Stebalien
Copy link
Member

No description provided.

- If we run them on all pull requests and pushes, we'll run them twice.
- If we run them only on push, we won't run them for forks.

Basically: If you want CI, open a PR.
@Stebalien Stebalien merged commit 29964a8 into master Apr 6, 2022
@Stebalien Stebalien deleted the chore/run-actions-on-pull branch April 6, 2022 20:23
@vmx
Copy link
Contributor

vmx commented Apr 7, 2022

I highly prefer running CI on branches before I open a PR. I want to reduce noise for other folks. I usually push on a branch and only PR once it is green. This workflow doesn't work anymore.

@galargh
Copy link
Contributor

galargh commented Apr 7, 2022

Myself, I usually use draft PRs to handle in-progress work.

In a lot of PL Go repositories, we run CI on both all pushes and pull_requests. You could do that here too but, unfortunately, since we don't have a way to monitor GitHub Actions usage yet, it'll be hard to tell what it means in terms of runners availability. You can always check in practice if such setup affects you negatively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants