feat: introduce network versions 19 and 20 #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1726 +/- ##
==========================================
- Coverage 55.62% 55.61% -0.01%
==========================================
Files 146 146
Lines 14016 14016
==========================================
- Hits 7796 7795 -1
- Misses 6220 6221 +1
|
ZenGround0
reviewed
Mar 24, 2023
shared/src/version/mod.rs
Outdated
| @@ -50,6 +51,10 @@ impl NetworkVersion { | |||
| pub const V17: Self = Self(17); | |||
| /// Hygge (builtin-actors v10) | |||
| pub const V18: Self = Self(18); | |||
| /// Lightning (builtin-actors v11) | |||
| pub const V19: Self = Self(19); | |||
| /// Lightning (builtin-actors v11) | |||
There was a problem hiding this comment.
Idk how we're thinking about actors versioning now but wouldn't this be v12?
There was a problem hiding this comment.
No, because FIP-0061 proposes a 2-stage upgrade, with a rollover period.
There was a problem hiding this comment.
Call the second one Thunder, maybe?
There was a problem hiding this comment.
That's such a good idea, it's worth re-running CI.
ZenGround0
approved these changes
Mar 24, 2023
Stebalien
approved these changes
Mar 27, 2023
shared/src/version/mod.rs
Outdated
| @@ -50,6 +51,10 @@ impl NetworkVersion { | |||
| pub const V17: Self = Self(17); | |||
| /// Hygge (builtin-actors v10) | |||
| pub const V18: Self = Self(18); | |||
| /// Lightning (builtin-actors v11) | |||
| pub const V19: Self = Self(19); | |||
| /// Lightning (builtin-actors v11) | |||
There was a problem hiding this comment.
Call the second one Thunder, maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title.