fix: cli: remove requirements in helptext #9969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The current
lotus-worker run
help text outputs the hw-requirements for some of the sealing-tasks.A lot of the requirements in this text is wrong, as for example the PC1 requires 64GiB of memory, and might also use up to a single core complex (1 main core, 3 producer threads) if the FIL_PROOFS_USE_MULTICORE_SDR=1 enviroment variable is exported. I propose that we remove the the sealing hw-requirements from this helptext as there are a lot of nuances that is hard to communicate in the space available in the cli, and rather communicate them in the documentation https://lotus.filecoin.io/storage-providers/get-started/hardware-requirements/ - which has now been updated (only missing PRU/PRU2, but will update those hw-requirements on Monday):
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps