Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:sealing:Handle finalize replica update failures in fsm #8229

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

ZenGround0
Copy link
Contributor

Related Issues

#8225

Proposed Changes

Handle finalize replica update failure in fsm. We missed handling the failure event in the fsm.

Additional Info

This isn't going to fix the underlying problem with replica update finalization failure related to worker assignment but it will keep the sector in a good state in the FSM so operators can manipulate sectors without normal shutdown of state machine

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@ZenGround0 ZenGround0 requested a review from a team as a code owner March 2, 2022 16:36
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8229 (874124c) into master (6d464c4) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8229      +/-   ##
==========================================
- Coverage   40.63%   40.58%   -0.05%     
==========================================
  Files         666      666              
  Lines       72923    72925       +2     
==========================================
- Hits        29634    29600      -34     
- Misses      38091    38120      +29     
- Partials     5198     5205       +7     
Impacted Files Coverage Δ
cmd/lotus-miner/info.go 60.11% <ø> (ø)
extern/storage-sealing/fsm.go 57.09% <0.00%> (+0.64%) ⬆️
extern/storage-sealing/sector_state.go 92.30% <ø> (ø)
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
markets/loggers/loggers.go 88.88% <0.00%> (-11.12%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
extern/sector-storage/worker_tracked.go 79.46% <0.00%> (-7.15%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
miner/warmup.go 70.83% <0.00%> (-4.17%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-1.97%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d464c4...874124c. Read the comment docs.

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is what I would expect, yeeee

@ZenGround0 ZenGround0 merged commit 14b7674 into master Mar 2, 2022
@ZenGround0 ZenGround0 deleted the fix/handle-finalize-ru-failure branch March 2, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants