Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Describe]: when excute cmd "lotus-bench sealing" without "benchmark-… #8173

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

xgswust
Copy link
Contributor

@xgswust xgswust commented Feb 23, 2022

when excute cmd "lotus-bench sealing" without "benchmark-existing-sectorbuilder", panic will occur
when don't set env "benchmark-existing-sectorbuilder" or the value of env "benchmark-existing-sectorbuilder" is null
var sealedSectors []saproof7.SectorInfo is not filled value,
wpvi1 := saproof2.WindowPoStVerifyInfo{
Randomness: challenge[:],
Proofs: wproof1,
ChallengedSectors: sealedSectors,
Prover: mid,
}
ok, err = ffiwrapper.ProofVerifier.VerifyWindowPoSt(context.TODO(), wpvi1)

will hanppen

2022-02-22T18:18:58.520+0800 WARN lotus-bench lotus-bench/main.go:117 no replicas supplied

Stack backtrace:
0: anyhow::error::::msg
1: filecoin_proofs_api::post::verify_window_post
2: <std::panic::AssertUnwindSafe as core::ops::function::FnOnce<()>>::call_once
3: ffi_toolkit::catch_panic_response
4: fil_verify_window_post
5: _cgo_24921690cad9_Cfunc_fil_verify_window_post
at /tmp/go-build/cgo-gcc-prolog:1741
6: runtime.asmcgocall
at /home/xjgw/.gvm/gos/go1.17.1/src/runtime/asm_amd64.s:765
github.com/filecoin-project/filecoin-ffi.VerifyWindowPoSt
/home/xjgw/eben-xgjw-local-network/.opensource-lotus/lotus-project/extern/filecoin-ffi/proofs.go:184
github.com/filecoin-project/lotus/extern/sector-storage/ffiwrapper.proofVerifier.VerifyWindowPoSt
/home/xjgw/eben-xgjw-local-network/.opensource-lotus/lotus-project/extern/sector-storage/ffiwrapper/verifier_cgo.go:163
main.glob..func3
/home/xjgw/eben-xgjw-local-network/.opensource-lotus/lotus-project/cmd/lotus-bench/main.go:428
github.com/urfave/cli/v2.(*Command).Run
/home/xjgw/.gvm/pkgsets/go1.17.1/global/pkg/mod/github.com/urfave/cli/[email protected]/command.go:164
github.com/urfave/cli/v2.(*App).RunContext
/home/xjgw/.gvm/pkgsets/go1.17.1/global/pkg/mod/github.com/urfave/cli/[email protected]/app.go:306
github.com/urfave/cli/v2.(*App).Run
/home/xjgw/.gvm/pkgsets/go1.17.1/global/pkg/mod/github.com/urfave/cli/[email protected]/app.go:215
main.main
/home/xjgw/eben-xgjw-local-network/.opensource-lotus/lotus-project/cmd/lotus-bench/main.go:116
runtime.main
/home/xjgw/.gvm/gos/go1.17.1/src/runtime/proc.go:255
runtime.goexit
/home/xjgw/.gvm/gos/go1.17.1/src/runtime/asm_amd64.s:1581

…existing-sectorbuilder", panic will occur

[BugFix]:

[FeatureAdd]:

[CodeReview]:

[ModifyDesc]:

[Author]:

[BugID]:
@xgswust xgswust requested a review from a team as a code owner February 23, 2022 03:12
@jennijuju
Copy link
Member

thank you for submitting!!

@jennijuju jennijuju linked an issue Feb 23, 2022 that may be closed by this pull request
18 tasks
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #8173 (e2cbad6) into master (5d416de) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8173      +/-   ##
==========================================
- Coverage   39.91%   39.84%   -0.08%     
==========================================
  Files         666      666              
  Lines       72554    72560       +6     
==========================================
- Hits        28963    28910      -53     
- Misses      38553    38601      +48     
- Partials     5038     5049      +11     
Impacted Files Coverage Δ
cmd/lotus-bench/main.go 0.00% <0.00%> (ø)
markets/loggers/loggers.go 88.88% <0.00%> (-11.12%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
cli/util.go 70.83% <0.00%> (-8.34%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-3.64%) ⬇️
miner/miner.go 55.08% <0.00%> (-2.96%) ⬇️
chain/gen/gen.go 68.19% <0.00%> (-1.23%) ⬇️
chain/vm/vm.go 61.63% <0.00%> (-1.07%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d416de...e2cbad6. Read the comment docs.

Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing

@ZenGround0 ZenGround0 merged commit ba65d1e into filecoin-project:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lotus-bench failed in v1.14.0-rc7
3 participants