Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lotus-miner sectors list --initial-pledge #8098

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Feb 15, 2022

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k requested a review from a team as a code owner February 15, 2022 13:22
@jennijuju
Copy link
Member

jennijuju commented Feb 15, 2022

Could you please add what this does in proposed change session of the pr description? So people who is reading this pr don’t have to check the code to get that info?

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #8098 (0b7addc) into master (bcaeb83) will decrease coverage by 0.11%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8098      +/-   ##
==========================================
- Coverage   39.47%   39.36%   -0.12%     
==========================================
  Files         666      666              
  Lines       72366    72369       +3     
==========================================
- Hits        28565    28486      -79     
- Misses      38876    38951      +75     
- Partials     4925     4932       +7     
Impacted Files Coverage Δ
cmd/lotus-miner/sectors.go 14.02% <50.00%> (+0.05%) ⬆️
itests/kit/blockminer.go 74.11% <0.00%> (-17.06%) ⬇️
markets/loggers/loggers.go 88.88% <0.00%> (-11.12%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-7.28%) ⬇️
extern/sector-storage/worker_tracked.go 79.46% <0.00%> (-7.15%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
node/impl/full/mpool.go 46.95% <0.00%> (-1.74%) ⬇️
miner/miner.go 55.08% <0.00%> (-1.32%) ⬇️
chain/vm/vm.go 61.63% <0.00%> (-1.07%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcaeb83...0b7addc. Read the comment docs.

@jennijuju
Copy link
Member

this is a super helpful cmd! Thank you!!

(which makes me think… If we can have a lotus-miner list —show-cc-only , the combo would work really well for figuring out whether to extend when cc expiration comes or snap regular deals!

@magik6k
Copy link
Contributor Author

magik6k commented Feb 15, 2022

You can do that with sectors list | grep CC

@magik6k magik6k merged commit 6f21a10 into master Feb 15, 2022
@magik6k magik6k deleted the feat/sectorlist-pledge branch February 15, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants