Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: appimage: re-install appimage CI #7943

Merged
merged 2 commits into from
Mar 2, 2022
Merged

ci: appimage: re-install appimage CI #7943

merged 2 commits into from
Mar 2, 2022

Conversation

coryschwartz
Copy link

@coryschwartz coryschwartz commented Jan 13, 2022

Related Issues

fix: #7733

Proposed Changes

Additional Info

This was disabled due to a bug in #7707

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@jennijuju
Copy link
Member

wooooaaaaa
Thanks Cory!

@coryschwartz
Copy link
Author

I just force-pushed to clean up my troubleshooting commit, but while I was troubleshooting I created circle job, so this shows that the CI job works.

https://app.circleci.com/pipelines/github/filecoin-project/lotus/18941/workflows/db3af609-c58f-4b29-a9c2-e2801f975e18/jobs/345976

I don't really like making a fake device, but there is no way to configure appimage-builder not to pass the device.

@coryschwartz coryschwartz changed the title fix appimage ci: appimage: re-install appimage CI Jan 14, 2022
@coryschwartz coryschwartz marked this pull request as ready for review January 15, 2022 02:36
@coryschwartz coryschwartz requested a review from a team as a code owner January 15, 2022 02:36
@ognots
Copy link
Contributor

ognots commented Feb 15, 2022

what's required to get this merged?

@magik6k magik6k merged commit a74c466 into master Mar 2, 2022
@magik6k magik6k deleted the fix/restore-appimage branch March 2, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get AppImage back!
4 participants