-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add check manual-stateless-deal with interactive deal making #7560
fix: add check manual-stateless-deal with interactive deal making #7560
Conversation
fix checking manual-stateless-deal with interactive deal making as --manual-stateless-deal can not be combined with interactive deal mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I definitely missed that
( no idea what lint
is unhappy about... )
need |
Can / Should I do something to pass these failed tests? |
Yes, run |
Codecov Report
@@ Coverage Diff @@
## master #7560 +/- ##
==========================================
- Coverage 39.90% 39.83% -0.08%
==========================================
Files 633 633
Lines 67098 67101 +3
==========================================
- Hits 26776 26728 -48
- Misses 35723 35771 +48
- Partials 4599 4602 +3
Continue to review full report at Codecov.
|
Hello @EmadMF! This contribution to the Filecoin codebase was voted as impactful during Q1 and is eligible for a FIL prize as part of a Protocol Labs experiment to reward open source contributions from the community (see full details here). Please reach out to us through [email protected] to receive the instructions on how to claim your reward! |
add check manual-stateless-deal with interactive deal making as --manual-stateless-deal can not be combined with interactive deal mode.