Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove job to install jq #7309

Merged
merged 1 commit into from
Sep 10, 2021
Merged

remove job to install jq #7309

merged 1 commit into from
Sep 10, 2021

Conversation

ognots
Copy link
Contributor

@ognots ognots commented Sep 9, 2021

jq is already installed now in either a newer version of CircleCI's MacOS VMs or in a previous CI step.
I ran a failing macos job with ssh enabled, and inspected '/usr/local/bin' and found found the following output

lrwxr-xr-x 1 distiller admin 23 Jun 22 14:50 jq -> ../Cellar/jq/1.6/bin/jq

the existing symlink causes the 'Install jq' job to fail.
removing this job should resolve the issue

@ognots ognots requested a review from a team as a code owner September 9, 2021 21:39
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle config is generated from .circleci/template.yml, so the change also needs to be done there

@ognots
Copy link
Contributor Author

ognots commented Sep 10, 2021

@magik6k updated template.yaml and pushed

jq is already installed now in either a newer version of CircleCI's MacOS VMs or in a previous CI step.
I ran a failing macos job with ssh enabled, and inspected '/usr/local/bin' and found found the following output

lrwxr-xr-x    1 distiller  admin    23 Jun 22 14:50 jq -> ../Cellar/jq/1.6/bin/jq

the existing symlink causes the 'Install jq' job to fail.
removing this job should resolve the issue
@ognots
Copy link
Contributor Author

ognots commented Sep 10, 2021

sorry previous comment jumped the gun. change is there now

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #7309 (4d9b852) into master (1ce7c25) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7309      +/-   ##
==========================================
+ Coverage   39.14%   39.21%   +0.07%     
==========================================
  Files         614      614              
  Lines       64989    64989              
==========================================
+ Hits        25437    25484      +47     
+ Misses      35145    35104      -41     
+ Partials     4407     4401       -6     
Impacted Files Coverage Δ
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
storage/wdpost_sched.go 77.22% <0.00%> (-3.97%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
extern/storage-sealing/fsm.go 57.42% <0.00%> (-1.61%) ⬇️
chain/messagepool/messagepool.go 56.93% <0.00%> (-0.62%) ⬇️
node/impl/storminer.go 22.46% <0.00%> (-0.40%) ⬇️
chain/sync.go 64.94% <0.00%> (-0.34%) ⬇️
chain/messagepool/selection.go 80.52% <0.00%> (ø)
extern/sector-storage/sched_worker.go 77.25% <0.00%> (ø)
markets/storageadapter/dealpublisher.go 81.46% <0.00%> (+0.48%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce7c25...4d9b852. Read the comment docs.

@magik6k magik6k merged commit aae9bf3 into master Sep 10, 2021
@magik6k magik6k deleted the ci/mac-os-jq-fix branch September 10, 2021 16:21
@jennijuju
Copy link
Member

thanks @ognots ! backported to release/v1.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants