Correct the config comment for SimultaneousTransfers, where it only applies to retrieval deals #7066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplies to retrieval deals.
This was referenced Aug 16, 2021
raulk
reviewed
Aug 17, 2021
| @@ -307,8 +307,7 @@ type Client struct { | |||
| IpfsOnlineMode bool | |||
| IpfsMAddr string | |||
| IpfsUseForRetrieval bool | |||
| // The maximum number of simultaneous data transfers between the client | |||
| // and storage providers | |||
| // The maximum number of simultaneous data transfers between the storage provider and retrieval client | |||
There was a problem hiding this comment.
This would only be for storage deals AFAIK.
|
Closing for now - will reopen soon after figuring out a better and clearer explanation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hannahhoward has confirmed that Simultaneous transfers in graphsync ONLY affect the responder, and for storage deals the storage provoider is the receiving side so the configuration wont be effective.