Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Integrate FIP0013 #6235
WIP: Integrate FIP0013 #6235
Changes from 34 commits
506f39b
5f8c805
8f42f37
6278bdc
578bef4
2afe725
ba2032c
febf7cf
357c086
e56960f
fe9311e
74bad49
6b3e04b
7512748
c544f4c
5614520
c7ba083
81b5d8c
d92c5e1
f66b9c5
1946d2f
9690bc8
e400bdf
0419c64
dd393b4
5112b9f
2a0c0e3
eafaf6d
a5677d1
2a1b359
e088c71
5113936
44bf9bf
7edffcd
678812f
bb889a5
d71334c
f3fda4a
13ff6ed
e3255a0
f540984
d90ab2b
04658e1
7bd0fcb
4c6c9a0
fc76a09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that bumping to version 3 in actors v4 was a mistake and that we were not planning to continue bumping the version every time. Is this intentional? If so what changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I just assumed that /something/ is expecting this to be bumped based on the nv12 diff, might have been wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the only good reason for it is version check in
chain/stmgr/forks.go:upgradeActorsV5Common
, I'm ok with dropping thatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I defer to you and @arajasek