Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin implementing storage miner #61

Merged
merged 21 commits into from
Jul 24, 2019
Merged

Begin implementing storage miner #61

merged 21 commits into from
Jul 24, 2019

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jul 18, 2019

#36

@magik6k magik6k force-pushed the feat/storminer-structure branch from 3a18c08 to 0fe19dd Compare July 18, 2019 23:18
Kubuxu
Kubuxu reviewed Jul 23, 2019
View reviewed changes
go.mod Outdated Show resolved Hide resolved
Kubuxu
Kubuxu reviewed Jul 23, 2019
View reviewed changes
node/repo/fsrepo.go Outdated Show resolved Hide resolved
@magik6k magik6k force-pushed the feat/storminer-structure branch from 5904920 to d1c8870 Compare July 23, 2019 21:45
@magik6k magik6k force-pushed the feat/storminer-structure branch from 91bcebf to d0cbf02 Compare July 23, 2019 23:49
whyrusleeping
whyrusleeping reviewed Jul 24, 2019
View reviewed changes
cmd/lotus-storage-miner/init.go

log.Info("Trying to connect to full node RPC")

api, err := lcli.GetAPI(cctx) // TODO: consider storing full node address in config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this TODO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a bit tricky, I think we can handle this later - #76

whyrusleeping
whyrusleeping reviewed Jul 24, 2019
View reviewed changes
node/repo/fsrepo.go Outdated Show resolved Hide resolved
whyrusleeping
whyrusleeping approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i like how easy it is to break this up. We probably will want to use the same tactic to break things up even a little more down the road

@magik6k magik6k mentioned this pull request Jul 24, 2019
Closed
whyrusleeping
whyrusleeping approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it!

@magik6k magik6k merged commit 1e10bf8 into master Jul 24, 2019
@magik6k magik6k deleted the feat/storminer-structure branch July 24, 2019 21:30
magik6k added a commit that referenced this pull request Aug 10, 2020
@magik6k
Merge pull request #61 from filecoin-project/feat/ffi-0.30.1
4c1968f 
Fileconi-FFI 0.30.1
magik6k added a commit that referenced this pull request Aug 10, 2020
@magik6k
Merge pull request #61 from filecoin-project/fix/addpiece-math
12e79a1 
Fixes to math in AddPiece
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu left review comments

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magik6k @whyrusleeping @Kubuxu