[EXPERIMENTAL] lmdb support for splitstore #5699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts in the hotstore
overkill, but let's not have race detectors scream at us.
raulk
changed the title
raulk
changed the title
vyzo
changed the title
6 tasks
vyzo
approved these changes
Mar 1, 2021
Co-authored-by: Raúl Kripalani <[email protected]>
raulk
force-pushed
the
feat/splitstore-lmdb
branch
from
9ea7297 to
a12a78b
Compare
vyzo
force-pushed
the
feat/splitstore
branch
2 times, most recently
from
ce3ff15 to
0a2f2cf
Compare
|
We decided against LMDB because it introduces many edge cases, and the performance gain for the dataset sizes we're dealing with is lower than expected. Therefore, the tradeoff is not justified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces experimental LMDB support to the splitstore.