Remove all temp file generation for deals #4929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
dirkmc
reviewed
Nov 20, 2020
hannahhoward
force-pushed
the
feat/update-markets-commp-extraction
branch
from
198596b to
6a5783a
Compare
hannahhoward
force-pushed
the
feat/update-markets-commp-extraction
branch
from
6a5783a to
218f7c2
Compare
magik6k
approved these changes
Nov 23, 2020
Kubuxu
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Reduce space required for temporary storage by generating CommP in pieces and removing use of temporary files in markets for online deals (still there for offline deals for now)
Implementation
For discussion
I removed any internal copies of the code in go-commp-utils. However, for the ffiwrapper, which is only a partial extraction, it results in some slightly awkward imports. Alternatively, we could just live with the extra copies of the files.
fix #4898 fix #4899