fix(miner): fix new bug in StateMinerPreCommitDepositForPower calculation #12595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced by refactoring in #12384 where the NV16 special case was missed and the full sector weight calculation was applied. The lack of this special case essentially reverts FIP-0034 for this API, but not for actors which would have a different PCD calculation.
--
Not doing a CHANGELOG for this one because #12384 hasn't got to a final release yet.
Also haven't included a test here, even though I'd love to, because I don't have time to figure out how on earth to pull that off. But thanks to @LesnyRumcajs for pointing out the bug due to the Forest compatibility tests where this request:
Was resulting in a value of:
"26167664014885767245"
for 1.30.0-rc when it should be"261676640148857672456"
(1.29.2 and Forest).