Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(f3): log when gaining/losing participation leases #12581

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Stebalien
Copy link
Member

Proposed Changes

Log whenever we start/stop participating for a storage miner in F3. Given that we use overlapping leases, we expect that we'll start participating for a miner on start then continue to participate over time.

This could get a bit noisy for setups that constantly switch between different lotus nodes but there's not much I can do about that and this will really help with debugging.

Checklist

Before you mark the PR ready for review, please make sure that:

@Stebalien Stebalien added the skip/changelog This change does not require CHANGELOG.md update label Oct 10, 2024
@Stebalien Stebalien requested review from masih and rvagg and removed request for masih October 10, 2024 22:52
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but it'd be nice to get t in there for testnet prefix; we need a MustNewAddress(id) for this kind of thing.

@Stebalien Stebalien force-pushed the steb/log-participation-change branch from f3bb338 to 5f5a0e9 Compare October 11, 2024 02:40
@Stebalien
Copy link
Member Author

ok, but it'd be nice to get t in there for testnet prefix; we need a MustNewAddress(id) for this kind of thing.

I just removed the f0 prefix. I agree we should have a better way to do this, but I don't want to have to deal with creating/formatting an address just for logging. And an ID is sufficient here.

@Stebalien Stebalien enabled auto-merge (squash) October 11, 2024 02:42
@Stebalien Stebalien merged commit 876843a into master Oct 11, 2024
83 checks passed
@Stebalien Stebalien deleted the steb/log-participation-change branch October 11, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

4 participants