fix: set address current network for non-mainnet since default is changed #12574
Conversation
Default `address.CurrentNetwork` was changed in an upstream dependency. Update the build constants for non-mainnet to explicitly set it to `Testnet`. Add tests to assert it.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
masih
changed the title
github-actions
bot
dismissed
their stale review
PR title now matches the required format.
|
@masih I believe you can just set this once here: https://github.com/filecoin-project/lotus/blob/v1.30.0-rc1/build/buildconstants/params_shared_vals.go#L22-L26 But I might be wrong |
|
Honestly, I'd rather be explicit. Also, we desperately need some form of shared "testnet" params file. |
|
+1 for explicit setting. But true fix would be to get rid of build params entirely, which is a battle best fought hydrated. |
…12574) Default `address.CurrentNetwork` was changed in an upstream dependency. Update the build constants for non-mainnet to explicitly set it to `Testnet`. Add tests to assert it.
…12574) Default `address.CurrentNetwork` was changed in an upstream dependency. Update the build constants for non-mainnet to explicitly set it to `Testnet`. Add tests to assert it.
…12574) Default `address.CurrentNetwork` was changed in an upstream dependency. Update the build constants for non-mainnet to explicitly set it to `Testnet`. Add tests to assert it.
Related Issues
Proposed Changes
Default
address.CurrentNetworkwas changed in an upstream dependency. Update the build constants for non-mainnet to explicitly set it toTestnet.Add tests to assert it.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: