test: validate MCOPY opcode for FIP-0094 #12556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be clear, this isn't work I have done. I am only creating the PR so that we have something tangible on the nv24 track project board. |
|
Per https://filecoinproject.slack.com/archives/CP50PPW2X/p1728030176551119?thread_ts=1728008390.565939&cid=CP50PPW2X @snissn has requested some debug help from @rvagg . |
Stebalien
reviewed
Oct 8, 2024
|
For visibility and cross-linking, there is an mcopy test in builtin-actors as well: filecoin-project/builtin-actors#1583 |
Stebalien
reviewed
Oct 8, 2024
rvagg
reviewed
Oct 9, 2024
rvagg
reviewed
Oct 9, 2024
rvagg
reviewed
Oct 9, 2024
rvagg
reviewed
Oct 9, 2024
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
rvagg
reviewed
Oct 14, 2024
rvagg
approved these changes
Oct 14, 2024
|
Awesome, thanks @snissn, all done |
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
--------- Co-authored-by: Rod Vagg <[email protected]> Co-authored-by: Mikers <[email protected]>
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
--------- Co-authored-by: Rod Vagg <[email protected]> Co-authored-by: Mikers <[email protected]>
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
--------- Co-authored-by: Rod Vagg <[email protected]> Co-authored-by: Mikers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an itest to validate that the MCOPY work of FIP-0094 is having its desired effect.
Related Issues
https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0094.md
filecoin-project/FIPs#1047
filecoin-project/builtin-actors#1572
Checklist
Before you mark the PR ready for review, please make sure that: