-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(f3): prepare for f3 bootstrap #12552
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/f3-bootstrap
branch
from
October 3, 2024 20:01
e9654a1
to
21e5a25
Compare
Stebalien
force-pushed
the
steb/f3-bootstrap
branch
6 times, most recently
from
October 3, 2024 22:45
a1be71f
to
bdd5575
Compare
This patch: 1. Bootstraps F3 when we hit the `F3BootstrapEpoch` (when non-negative). 2. Refuses any/all dynamic manifests once we get within one finality of said epoch. 3. Sets the F3 network name for mainnet to "filecoin". 4. Refuses any/all dynamic manifests that don't start with the expected network name prefix.
Stebalien
force-pushed
the
steb/f3-bootstrap
branch
from
October 3, 2024 22:54
bdd5575
to
16204dc
Compare
I still need to write a bootstrap test, but this is ready for an initial review. |
Stebalien
commented
Oct 4, 2024
(for better test coverage)
Stebalien
force-pushed
the
steb/f3-bootstrap
branch
from
October 4, 2024 20:47
a33eefb
to
b76e6b9
Compare
Stebalien
added
the
skip/changelog
This change does not require CHANGELOG.md update
label
Oct 4, 2024
Stebalien
force-pushed
the
steb/f3-bootstrap
branch
from
October 4, 2024 23:49
53c671f
to
16f4ac0
Compare
Kubuxu
approved these changes
Oct 7, 2024
2 tasks
masih
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the slow review 👍
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes #596
Proposed Changes
This patch:
F3BootstrapEpoch
(when non-negative).Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: