Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky wdPost dispute itest #12243

Merged
merged 3 commits into from
Jul 16, 2024
Merged

fix: flaky wdPost dispute itest #12243

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9d4775
fix flaky wdPost dispute test
aarshkshah1992 Jul 16, 2024
3e3ffa6
reduce diff
aarshkshah1992 Jul 16, 2024
7cc8606
changes as per review
aarshkshah1992 Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions itests/wdpost_dispute_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (

"github.com/filecoin-project/go-address"
"github.com/filecoin-project/go-bitfield"
"github.com/filecoin-project/go-state-types/abi"
"github.com/filecoin-project/go-state-types/builtin"
minertypes "github.com/filecoin-project/go-state-types/builtin/v8/miner"
"github.com/filecoin-project/go-state-types/crypto"
Expand Down Expand Up @@ -285,36 +286,34 @@ func TestWindowPostDisputeFails(t *testing.T) {

// Wait until a proof has been submitted.
var targetDeadline uint64
var dInfo *dline.Info
waitForProof:
for {
head, err := client.ChainHead(ctx)
require.NoError(t, err)

di, err := client.StateMinerProvingDeadline(ctx, maddr, head.Key())
require.NoError(t, err)

deadlines, err := client.StateMinerDeadlines(ctx, maddr, types.EmptyTSK)
require.NoError(t, err)
for dlIdx, dl := range deadlines {
nonEmpty, err := dl.PostSubmissions.IsEmpty()
rvagg marked this conversation as resolved.
Show resolved Hide resolved
require.NoError(t, err)
if nonEmpty {
if nonEmpty && di.Index == uint64(dlIdx) {
rvagg marked this conversation as resolved.
Show resolved Hide resolved
targetDeadline = uint64(dlIdx)
dInfo = di
break waitForProof
}
}

build.Clock.Sleep(blocktime)
}

for {
//stm: @CHAIN_STATE_MINER_CALCULATE_DEADLINE_001
di, err := client.StateMinerProvingDeadline(ctx, maddr, types.EmptyTSK)
require.NoError(t, err)
// wait until the deadline finishes.
if di.Index == ((targetDeadline + 1) % di.WPoStPeriodDeadlines) {
break
}

build.Clock.Sleep(blocktime)
}

// Try to object to the proof. This should fail.
{
disputeEpoch := dInfo.Close + 5
_ = client.WaitTillChain(ctx, heightAtLeast(disputeEpoch))

params := &minertypes.DisputeWindowedPoStParams{
Deadline: targetDeadline,
PoStIndex: 0,
Expand All @@ -330,13 +329,19 @@ waitForProof:
Value: types.NewInt(0),
From: defaultFrom,
}
_, err := client.MpoolPushMessage(ctx, msg, nil)
_, err = client.MpoolPushMessage(ctx, msg, nil)
require.Error(t, err)
require.Contains(t, err.Error(), "failed to dispute valid post")
require.Contains(t, err.Error(), "(RetCode=16)")
}
}

func heightAtLeast(target abi.ChainEpoch) func(set *types.TipSet) bool {
rvagg marked this conversation as resolved.
Show resolved Hide resolved
return func(ts *types.TipSet) bool {
return ts.Height() >= target
}
}

func submitBadProof(
ctx context.Context,
client api.FullNode, owner address.Address, maddr address.Address,
Expand Down
Loading