-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: api itest panic #12238
fix: api itest panic #12238
Conversation
This breaks 2 public APIs, which while we may not expect people to be using them, we should at least signal and not just roll this out in a casual patch release. My preference for signalling breakage is in commit message, which, if we can do consistently, will really help our changelog, so your commit message could be something like:
Also API breakage may be something we shouldn't skip changelog on? |
Yes, we should add this the changelog / write down what the API´s we are breaking - so its clear/understandable what should be added in a |
storage/pipeline.NewPreCommitBatcher and storage/pipeline.New now have an additional error return to deal with errors arising from fetching the sealing config.
a75a6b8
to
851a298
Compare
@rvagg Addressed your review. Please can you review ? |
for the record, examples of failures that we're attempting to fix here: |
Fixes flakiness in
testNonGenesisMiner
inapi_test
by de-racing the closing of the miner repo and the sealer reading it in a go-routine. If the go-routine gets scheduled after the miner repo is closed in the test, this causes a panic which fails the test. The right thing to do here is for the sealer to read the repo when it is instantiated and pass the config to the go-routine.Adds some logging to the
testOutOfGasError
itest to see what's going on when it fails (very very rare).