fix: shed: backfill events from correct starting height #11720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
If we want to get events and other indices for the
from
height, we need to be starting from a tipset that is guaranteed to be later thanfrom
. The current code will incorrectly return the tipset atfrom
in the event that the tipset atfrom+1
is null, and thus miss one epoch.Proposed Changes
Request the tipset using
ChainGetTipSetAfterHeight(from+1)
. Iffrom+1
is non-null, this will make no difference. Iffrom
is null, this will now return the first non-null tipset at a greater height, thus giving us a tipset whose parent is atfrom
height (or earlier, assumingfrom
itself is null). I believe that's what we want for this code.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps