Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sealing pipeline: Fix panic on padding pieces in WaitDeals #11708

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 12, 2024

Related Issues

Fixes #11706

Proposed Changes

  • Don't use padding pieces (which have no deal info) for calculating deal end epoch in WaitDeals
  • Make the pieceinfo methods safer
  • Catch panics in the sealing pipeline

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 12, 2024 08:06
@magik6k magik6k mentioned this pull request Mar 12, 2024
11 tasks
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also handle?

func (sp *SafeSectorPiece) Key() piece.PieceKey {
	return sp.real.DealInfo.Key()
}
func (sp *SafeSectorPiece) Valid(nv network.Version) error {
	return sp.real.DealInfo.Valid(nv)
}

@LexLuthr LexLuthr changed the base branch from release/v1.26.0 to master March 12, 2024 13:09
storage/pipeline/input.go Show resolved Hide resolved
@snadrus snadrus merged commit 81e65db into master Mar 12, 2024
90 checks passed
@snadrus snadrus deleted the fix/lm-padding-panic branch March 12, 2024 16:22
rjan90 pushed a commit that referenced this pull request Mar 13, 2024
* sealing pipeline: Fix panic on padding pieces in WaitDeals

* sealing pipeline: Catch panics
rjan90 added a commit that referenced this pull request Mar 13, 2024
* enable storing events (#11712)

* fix: commit batch: Always go through commit batcher (#11704)

* fix: commit batch: Always go through commit batcher

* fix sealing fsm tests

* sealing pipeline: Fix panic on padding pieces in WaitDeals (#11708)

* sealing pipeline: Fix panic on padding pieces in WaitDeals

* sealing pipeline: Catch panics

* sealing pipeline: Output DDO pieces in SectorStatus (#11709)

* sealing pipeline: Fix failing ProveCommit3 aggregate (#11710)

* itests: Repro failing ProveCommit3 aggregate

* commit batch: Correctly sort sectors in processBatchV2

* fix imports

* ci: Bigger instance for sector_pledge test

* itests: Use Must-Post mining in TestPledgeBatching

---------

Co-authored-by: Aarsh Shah <[email protected]>
Co-authored-by: Łukasz Magiera <[email protected]>
rjan90 added a commit that referenced this pull request Mar 22, 2024
* enable storing events (#11712)

* fix: commit batch: Always go through commit batcher (#11704)

* fix: commit batch: Always go through commit batcher

* fix sealing fsm tests

* sealing pipeline: Fix panic on padding pieces in WaitDeals (#11708)

* sealing pipeline: Fix panic on padding pieces in WaitDeals

* sealing pipeline: Catch panics

* sealing pipeline: Output DDO pieces in SectorStatus (#11709)

* sealing pipeline: Fix failing ProveCommit3 aggregate (#11710)

* itests: Repro failing ProveCommit3 aggregate

* commit batch: Correctly sort sectors in processBatchV2

* fix imports

* ci: Bigger instance for sector_pledge test

* itests: Use Must-Post mining in TestPledgeBatching

---------

Co-authored-by: Aarsh Shah <[email protected]>
Co-authored-by: Łukasz Magiera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lotus-miner panic when sealing
4 participants