Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add StateMinerDeadlines to gateway #11700

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

qwdsds
Copy link
Contributor

@qwdsds qwdsds commented Mar 11, 2024

Related Issues

Proposed Changes

Add StateMinerDeadlines to gateway.

#11693

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@rvagg
Copy link
Member

rvagg commented Mar 11, 2024

lgtm as per discussion in #11693

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to work you'll also need to add a proxy method in https://github.com/filecoin-project/lotus/blob/master/gateway/proxy_fil.go which just needs to check that the tipset is recent enough. Without that this method won't work correctly on lotus-gateway

@qwdsds
Copy link
Contributor Author

qwdsds commented Mar 11, 2024

For this to work you'll also need to add a proxy method in https://github.com/filecoin-project/lotus/blob/master/gateway/proxy_fil.go which just needs to check that the tipset is recent enough. Without that this method won't work correctly on lotus-gateway

StateMinerDeadlines are already in this gateway/proxy_fil.go

@qwdsds qwdsds requested a review from magik6k March 11, 2024 12:11
@qwdsds qwdsds force-pushed the feat/add-api-to-gateway branch from 228ce4a to 0a0618e Compare March 13, 2024 01:06
@rvagg
Copy link
Member

rvagg commented Mar 13, 2024

still seems fine to me, needs @magik6k to re-review

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this exists in proxy_fil.go and the lookback limit is being enforced.

@Stebalien Stebalien merged commit b909db3 into filecoin-project:master Mar 14, 2024
90 checks passed
@qwdsds qwdsds deleted the feat/add-api-to-gateway branch September 13, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants