-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add StateMinerDeadlines to gateway #11700
feat: add StateMinerDeadlines to gateway #11700
Conversation
4304864
to
228ce4a
Compare
lgtm as per discussion in #11693 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this to work you'll also need to add a proxy method in https://github.com/filecoin-project/lotus/blob/master/gateway/proxy_fil.go which just needs to check that the tipset is recent enough. Without that this method won't work correctly on lotus-gateway
StateMinerDeadlines are already in this gateway/proxy_fil.go |
228ce4a
to
0a0618e
Compare
still seems fine to me, needs @magik6k to re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that this exists in proxy_fil.go
and the lookback limit is being enforced.
Related Issues
Proposed Changes
Add StateMinerDeadlines to gateway.
#11693
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps