Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: curio: base config by default #11676

Merged
merged 2 commits into from
Mar 6, 2024
Merged

fix: curio: base config by default #11676

merged 2 commits into from
Mar 6, 2024

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Mar 4, 2024

Related Issues

Proposed Changes

The base layer will now be applied by default for all Curio instances.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@LexLuthr LexLuthr requested a review from a team as a code owner March 4, 2024 15:02
@LexLuthr LexLuthr requested a review from snadrus March 4, 2024 15:03
@LexLuthr
Copy link
Contributor Author

LexLuthr commented Mar 4, 2024

@snadrus We have a global flag --layers and then local flags --layers. This is very confusing a user and can lead to conflict in flags. I would vote to move --layers to local flag and add it to the commands requiring it.

@LexLuthr LexLuthr merged commit 40f3071 into master Mar 6, 2024
88 checks passed
@LexLuthr LexLuthr deleted the curio/config-base branch March 6, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants