-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
harmony storage #11647
harmony storage #11647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, but this looks much closer.
lib/harmony/resources/resources.go
Outdated
|
||
// This allows some other system to consider the task done. | ||
// It's up to the caller to remove the data, if that applies. | ||
MarkComplete() error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MarkComplete should also have the taskID param
7c7f89e
to
c92779f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the last commit this is sufficient to implement storage reservation mechanism for tasks in the sealing pipeline; I'll open a PR on top of this one with impl ported from my previous PR with the better harmony integration
Related Issues
This enables HarmonyTask tasks to express (kind-of-cleanly) the storage needs, the system to atomically reserve each need, and provide the paths to Do() without any API change to existing tasks.
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps