Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport #11294 into release/v1.23.4 #11295

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Sep 25, 2023

Proposed Changes

Backport #11294 to release/v1.23.4

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Connect to newAddress
use net.JoinHostPort(minerIP, minerPort) to handle both IPv4 and IPv6 addresses.
@rjan90 rjan90 requested a review from a team as a code owner September 25, 2023 13:15
@rjan90 rjan90 merged commit 6c8a0ea into release/v1.23.4 Sep 26, 2023
@rjan90 rjan90 deleted the phi-worker-connect-backport branch September 26, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants