fix: networking: avoid dialing when trying to handshake peers #11262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, avoid handshaking with peers that don't support the handshake protocol.
Stebalien
force-pushed
the
steb/fix-dial-spam
branch
from
0aa798a
to
cfaeb27
Compare
arajasek
force-pushed
the
steb/fix-dial-spam
branch
from
ab085e2
to
89dede3
Compare
Stebalien
added a commit
that referenced
this pull request
Sep 15, 2023
* fix: networking: avoid dialing when trying to handshake peers Also, avoid handshaking with peers that don't support the handshake protocol. * drop unused imports --------- Co-authored-by: Steven Allen <[email protected]>
1 task
rjan90
pushed a commit
that referenced
this pull request
Oct 17, 2023
* fix: networking: avoid dialing when trying to handshake peers Also, avoid handshaking with peers that don't support the handshake protocol. * drop unused imports --------- Co-authored-by: Steven Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Avoid dialing when trying to handshake peers. We're trying to handshake with connected peers, but that doesn't mean we want to re-connect if the connection was transient. Also, avoid handshaking with peers that don't support the handshake protocol.
Additional Info
Reported in slack https://filecoinproject.slack.com/archives/C03K82MU486/p1694181455279969
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps