Take Download out of Sealer time #11182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Aug 21, 2023
| @@ -412,6 +412,16 @@ func TestSealPoStNoCommit(t *testing.T) { | |||
| fmt.Printf("EPoSt: %s\n", epost.Sub(precommit).String()) | |||
| } | |||
|
|
|||
| func TestMain(m *testing.M) { | |||
| //setup() | |||
| // Here it no-longer is bound to 30s but has 1m30s for the whole suite. | |||
There was a problem hiding this comment.
What 30s timer? Is there some test time limit I'm not aware of? Where is that defined?
There was a problem hiding this comment.
Go tests fail after 30 seconds by default. When implementing TestMain, you get 1m30s for the whole setup + test, and the 30s test-body window still applies.
magik6k
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading a 1GB file during a unit test is bad enough, but doing it in serial with a 600mb file followed by a lot of work is too much.
A patch sent to Orjan downloads those in parallel.
This takes the download out of the 30s timer and into a 1m30m (all test targets) window.
This will buy more time for the test to complete no matter what the delay is (if the problem is a timeout).
IF this fixes CI, we should discuss why we are having repeated, enormous downloads from filecoin websites as part of unit testing.