Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: eth: deflake multiblock lookup test #10769

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

Stebalien
Copy link
Member

  • Increase epoch times to give the miners a chance to see each other's blocks.
  • Wait longer for a multi-block tipset.
  • Reduce the initial wait (we're increasing the block times and I don't really feel like waiting around).

This isn't exactly a fix, but it should (hopefully) reduce the chances of a flake. If it doesn't.... well, we'll have to try something else.

- Increase epoch times to give the miners a chance to see each other's
blocks.
- Wait longer for a multi-block tipset.
- Reduce the initial wait (we're increasing the block times and I don't
really feel like waiting around).
@Stebalien Stebalien requested a review from a team as a code owner April 26, 2023 21:21
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All sound reasonable to me.

@Stebalien Stebalien merged commit e351d77 into master Apr 26, 2023
@Stebalien Stebalien deleted the steb/deflake-eth-multiblock branch April 26, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants