-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: state: skip tipset execution when possible #10445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/skip-tipset-execution
branch
from
March 10, 2023 21:17
5e8ed1f
to
3a4cbb9
Compare
Stebalien
force-pushed
the
steb/skip-tipset-execution
branch
from
March 10, 2023 21:21
3a4cbb9
to
92bca48
Compare
7 tasks
arajasek
approved these changes
Mar 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I like how simple this is!
raulk
approved these changes
Mar 11, 2023
Merged so I can build on it. Thanks, @Stebalien! |
Note: I think @arajasek had expressed a pet peeve against using "deeper" methods from the Eth API (e.g. a StateManager method in this case). |
19 tasks
raulk
added a commit
that referenced
this pull request
Mar 13, 2023
raulk
added a commit
that referenced
this pull request
Mar 13, 2023
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Instead of always executing the tipset inside
StateManager.TipSetState
, try to find a successor tipset and return the parent state & receipts as recorded.Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps