chore: make debugging windowPoSt-failures human readable #10390
Conversation
beck-8
force-pushed
the
chore/compute-wdpost-human-readable
branch
from
d0c15ee to
668b24f
Compare
cmd/lotus-miner/proving.go
Outdated
| postParams = append(postParams, postParam) | ||
| } | ||
|
|
||
| jr, err := json.Marshal(postParams) |
There was a problem hiding this comment.
I would just output in a human readable format. This was outputting json because that was the simplest way to have some useful debug output.
There was a problem hiding this comment.
Sorry, I didn't understand what you meant. You mean it's not easy enough to use is it now?
There was a problem hiding this comment.
I think this is enough, if there is a more elegant way, please suggest it and I will learn.
lotus-miner proving compute window-post 0|grep -v Took|jq .
or
lotus-miner proving compute window-post 0|grep -v Took|jq .[].Partitions[].Skipped
There was a problem hiding this comment.
It is easy now, but I'm not sure if the output should be json as most commands output data in more human-readable form (and some commands have --json for json output)
e.g.
$ lotus-miner sectors status 1715 SectorID: 1715
Status: Proving
CIDcommD: baga6ea4seaqao7s73y24kcutaosvacpdjgfe5pw76ooefnyqw4ynr3d2y6x2mpq
[...]
I guess at least this json could be output with json.MarshalIndent.
Note that this is purely for consistency with other commands, there is nothing technically wrong with this approach.
There was a problem hiding this comment.
ok,I agree with standardization the output.
Related Issues
#8561
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps