fix: event filters use cbor encoding internally #10085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
approved these changes
Jan 23, 2023
9 tasks
geoff-vball
pushed a commit
that referenced
this pull request
Jan 27, 2023
Stebalien
added a commit
that referenced
this pull request
Feb 15, 2023
We merged #10085 without a migration, so the event database will contain both cbor and non-cbor values. We need to handle that.
Stebalien
added a commit
that referenced
this pull request
Feb 15, 2023
We merged #10085 without a migration, so the event database will contain both cbor and non-cbor values. We need to handle that.
Stebalien
added a commit
that referenced
this pull request
Feb 15, 2023
We merged #10085 without a migration, so the event database will contain both cbor and non-cbor values. We need to handle that.
Stebalien
added a commit
that referenced
this pull request
Feb 15, 2023
* fix: events: handle decoded events in database We merged #10085 without a migration, so the event database will contain both cbor and non-cbor values. We need to handle that. * fix: imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes filecoin-project/ref-fvm#1345
Proposed Changes
All cbor decoding/encoding of event log values by filters is now handled in the Eth API. Internally all values are kept as cbor encoded byte arrays.
NOTE: this invalidates previous data stored in the event log sqlite database so events indexed before this change will not be discoverable. Advise removing the database to start indexing to a new one.
Additional Info
This is currently based on #10083 which contains comprehensive itests for this area.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps