E2E Testing for FIP8 & FIP13

[Stebalien]

FIP8 and FIP13 will allow batched pre-commits and batched prove-commits. This process needs end-to-end testing at scale (100s of sectors, test match batch sizes).

1. We need unit/integration tests to verify pre/prove-commit batching.
   1. What happens when a single sector fails?
2. We need to test this in a dev-net.

[BigLep]

Discussion notes:

1. Scale

• 100's of sectors all at once

2. Assertions

• What happens if 1 of 100 sectors fail
• Pipeline is able to notice that we don't have enough sectors in a batch and thus wait.

[BigLep]

@magik6k and @vyzo : I want to make sure we're clear about the testing work for FIP8 and 13. Specifically I would like to know what we expect tested, that we have owners, and that we're tracking it (whether as a checklist or separate issues). I took a first stab below based on what I saw in this issue and in PR #6235. Please correct and ideally set as the subject of this issue or another.

In addition to making sure we don't lose track of anything, it'll be important as we update our estimates of the remaining work on 2021-05-20.

Item	Comment	Status
Unit tests for CommitBatcher	Owner: @magik6k | Issue/PR: #6432	Done
Unit tests for PrecommitBatcher	Owner: @magik6k | Issue/PR: #6432	Done
Precommit Batching integration test	Owner: @mention | Issue/PR: #XXXX
Commit Batching integration test	Owner: @mention | Issue/PR: #XXXX
Scale testing	This is automated verification that we can handle 100's of sectors Owner: @mention | Issue/PR: #XXXX

In batching unit/integration tests we'd want to check:

• Happy path
• One/multiple sector expires
• Deal within a sector expires
• Batch fails (e.g., out of gas)
• One/many porep fails (commit)

• that we always recover from those correctly

[magik6k]

(updated the comment above to have a better list of what needs to be done)

[arajasek]

#6432 adds unit tests for both the precommit and commit batchers

[arajasek]

• Unit tests landed in Unit tests for sector batchers #6432
• Integ tests landing soon from Magik
• Tested in a devnet

[BigLep]

I'm reopening this because I'm not seeing the integ tests PR created or merged (from looking https://github.com/filecoin-project/lotus/pulls?q=is%3Apr+sort%3Aupdated-desc+ ), but let me know if I have that wrong. I don't want to blur what "done" means.

[arajasek]

Tested on mainnet ;)