[wip] Test for deals expiring in batchers #6570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
reviewed
Jun 23, 2021
| return nil, nil | ||
| } | ||
|
|
||
| log.Info("processing batch: queued more than Max") |
There was a problem hiding this comment.
can this not happen at exactly Max?
|
Nice work! |
|
@gagizoned I don't think this should be in the milestone, but def good to get this across the finish line |
magik6k
force-pushed
the
test/batch-deal-expiring
branch
from
8efc517
to
317555b
Compare
magik6k
force-pushed
the
test/batch-deal-expiring
branch
from
317555b
to
cc856eb
Compare
|
After fighting with this test some more I'm pretty sure that this specific case can't actually happen, which is why it's basically impossible to make this test do what it says in the title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address #6157
Draft because the test is not triggering the expected logic yet / has some incorrect asserts, but already shows that the thing works at least ~80% as expected