Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TraceAPI: Support failures while creating contracts #11217

Closed
fridrik01 opened this issue Aug 29, 2023 · 0 comments · Fixed by #11609
Closed

TraceAPI: Support failures while creating contracts #11217

fridrik01 opened this issue Aug 29, 2023 · 0 comments · Fixed by #11609
Labels

Comments

@fridrik01
Copy link
Contributor

Left as TODO in: #11100
Relevant Comment: https://github.com/filecoin-project/lotus/pull/11100/files#r1305971682

We need to handle failures in contract creations and support resurrections on an existing but dead EVM actor)

We have a few cases:

  • Failures. I.e., we may fail halfway through this path for some reason and need to treat it as a failed to creation.
  • Resurrection! EAM "create" and/or "create2" may not call the init actor but may, instead call "resurrect" on an existing but dead EVM actor. Let's handle that later, but it's an important part of "EVM-style" code upgrades (which are not the same as FVM code upgrades).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants