Skip to content

Commit

Permalink
fix(f3): improve log messages (#12576)
Browse files Browse the repository at this point in the history
1. Change Restarting -> Renewing. Restarting sounds like something is
going wrong.
2. Fix spelling of rechecking.
  • Loading branch information
Stebalien authored Oct 10, 2024
1 parent e769bdf commit 0d9dcd7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions node/modules/storageminer.go
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ func (p *f3Participator) participate(ctx context.Context) error {
return ctx.Err()
}
}
log.Info("Restarting F3 participation")
log.Info("Renewing F3 participation")
}
return ctx.Err()
}
Expand Down Expand Up @@ -506,11 +506,11 @@ func (p *f3Participator) awaitLeaseExpiry(ctx context.Context, lease api.F3Parti
log.Errorw("Failed to check F3 progress while awaiting lease expiry. Retrying after backoff.", "attempts", p.backoff.Attempt(), "backoff", p.backoff.Duration(), "err", err)
p.backOff(ctx)
case progress.ID+2 >= lease.FromInstance+lease.ValidityTerm:
log.Infof("F3 progressed (%d) to within two instances of lease expiry (%d+%d). Restarting participation.", progress.ID, lease.FromInstance, lease.ValidityTerm)
log.Infof("F3 progressed (%d) to within two instances of lease expiry (%d+%d). Renewing participation.", progress.ID, lease.FromInstance, lease.ValidityTerm)
return nil
default:
remainingInstanceLease := lease.ValidityTerm - progress.ID
log.Debugf("F3 participation lease is valid for further %d instances. Recking after %s.", remainingInstanceLease, p.checkProgressInterval)
log.Debugf("F3 participation lease is valid for further %d instances. Re-checking after %s.", remainingInstanceLease, p.checkProgressInterval)
p.backOffFor(ctx, p.checkProgressInterval)
}
}
Expand Down

0 comments on commit 0d9dcd7

Please sign in to comment.