Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up (and fix) messages from --provider flag #317

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 15, 2023

These have been bugging me for a while; when in here I noticed the reason they seemed off is that one of these messages is wrong (the > 0 vs == 0).

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #317 (19c8abd) into main (e231251) will increase coverage by 0.46%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   72.21%   72.68%   +0.46%     
==========================================
  Files          68       68              
  Lines        6263     6257       -6     
==========================================
+ Hits         4523     4548      +25     
+ Misses       1484     1461      -23     
+ Partials      256      248       -8     
Impacted Files Coverage Δ
cmd/lassie/fetch.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvagg rvagg merged commit f131ae0 into main Jun 21, 2023
@rvagg rvagg deleted the rvagg/cmd-fetch-provider-msgs branch June 21, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants