Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: turn off debug in main itest #278

Merged
merged 1 commit into from
Jun 1, 2023
Merged

chore: turn off debug in main itest #278

merged 1 commit into from
Jun 1, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 1, 2023

I meant to push this turned off when I originally added it but obviously went back and did more tinkering with it on and never turned it back off again. It's noisy, slows down the tests, and only useful if you're debugging DAGs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Merging #278 (12af389) into main (4ed0ff7) will increase coverage by 0.28%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   71.18%   71.47%   +0.28%     
==========================================
  Files          69       69              
  Lines        6043     6043              
==========================================
+ Hits         4302     4319      +17     
+ Misses       1496     1484      -12     
+ Partials      245      240       -5     

see 6 files with indirect coverage changes

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvagg rvagg merged commit 871d92a into main Jun 1, 2023
@rvagg rvagg deleted the rvagg/nodebg branch June 1, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants