Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProtocolSucceeded to event #252

Merged
merged 2 commits into from
May 26, 2023
Merged

Add ProtocolSucceeded to event #252

merged 2 commits into from
May 26, 2023

Conversation

kylehuntsman
Copy link
Contributor

@kylehuntsman kylehuntsman commented May 25, 2023

Adds a ProtocolSucceeded property to the event for knowing which protocol was used for a successful request.

Notable Changes:

  • Updates events.RetrievalEventSuccess to have a protocol property that describes the protocol used for the successful retrieval.

References #247

@kylehuntsman kylehuntsman requested a review from hannahhoward May 25, 2023 10:46
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Merging #252 (e7bdb6f) into main (9292479) will increase coverage by 1.40%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   70.10%   71.51%   +1.40%     
==========================================
  Files          66       71       +5     
  Lines        5861     6330     +469     
==========================================
+ Hits         4109     4527     +418     
- Misses       1512     1551      +39     
- Partials      240      252      +12     
Impacted Files Coverage Δ
...g/aggregateeventrecorder/aggregateeventrecorder.go 89.56% <100.00%> (+0.35%) ⬆️
pkg/events/events.go 98.92% <100.00%> (+0.01%) ⬆️
pkg/retriever/bitswapretriever.go 93.57% <100.00%> (+0.02%) ⬆️
pkg/retriever/parallelpeerretriever.go 95.07% <100.00%> (+0.02%) ⬆️

... and 18 files with indirect coverage changes

@kylehuntsman kylehuntsman merged commit 84f781b into main May 26, 2023
@kylehuntsman kylehuntsman deleted the feat/success-protocol branch May 26, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants