Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize logger vars and names #237

Merged
merged 1 commit into from
May 16, 2023
Merged

Standardize logger vars and names #237

merged 1 commit into from
May 16, 2023

Conversation

kylehuntsman
Copy link
Contributor

Some loggers didn't have the lassie/ prefix making it difficult to review Saturn logs and determine which logs were lassie related. I opted for the clean import of github.com/ipfs/go-log/v2 and naming our Loggers logger.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #237 (edbd7a8) into main (b1a380c) will increase coverage by 0.04%.
The diff coverage is 23.43%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   70.89%   70.94%   +0.04%     
==========================================
  Files          68       68              
  Lines        6079     6079              
==========================================
+ Hits         4310     4313       +3     
+ Misses       1525     1523       -2     
+ Partials      244      243       -1     
Impacted Files Coverage Δ
cmd/lassie/daemon.go 0.00% <0.00%> (ø)
cmd/lassie/fetch.go 0.00% <0.00%> (ø)
cmd/lassie/main.go 0.00% <0.00%> (ø)
cmd/lassie/version.go 0.00% <0.00%> (ø)
...g/aggregateeventrecorder/aggregateeventrecorder.go 89.20% <0.00%> (ø)
pkg/eventrecorder/eventrecorder.go 77.11% <0.00%> (ø)
pkg/eventrecorder/filelogserver/filelogserver.go 0.00% <0.00%> (ø)
pkg/indexerlookup/candidatefinder.go 65.95% <ø> (ø)
pkg/metrics/exporter.go 0.00% <ø> (ø)
pkg/metrics/server.go 0.00% <0.00%> (ø)
... and 11 more

... and 4 files with indirect coverage changes

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hannahhoward
Copy link
Collaborator

but conflicts.

Some loggers didn't have the lassie/ prefix making it difficult to review Saturn logs and determine which logs were lassie related.
@hannahhoward
Copy link
Collaborator

rebased

@kylehuntsman kylehuntsman merged commit b5aa6be into main May 16, 2023
@kylehuntsman kylehuntsman deleted the refactor/logging branch May 16, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants