Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert use of pkg/aggregateeventrecorder to pkg/eventrecorder" #236

Merged
merged 1 commit into from
May 15, 2023
Merged

Revert "Revert use of pkg/aggregateeventrecorder to pkg/eventrecorder" #236

merged 1 commit into from
May 15, 2023

Conversation

willscott
Copy link
Contributor

Re-enable aggregate events

@willscott willscott requested a review from kylehuntsman May 15, 2023 16:07
hannahhoward
hannahhoward approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the double negative this is GTG.

@codecov-commenter
Copy link

Codecov Report

Merging #236 (fbb0888) into main (9a431c5) will decrease coverage by 0.55%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   71.13%   70.58%   -0.55%     
==========================================
  Files          68       68              
  Lines        6079     6079              
==========================================
- Hits         4324     4291      -33     
- Misses       1517     1538      +21     
- Partials      238      250      +12
Impacted Files Coverage Δ
cmd/lassie/main.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

@willscott willscott merged commit c8ddd7f into main May 15, 2023
@kylehuntsman kylehuntsman mentioned this pull request May 15, 2023
Closed
@kylehuntsman kylehuntsman deleted the revert-218-revert/eventrecorder branch May 15, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahhoward hannahhoward hannahhoward approved these changes

@kylehuntsman kylehuntsman Awaiting requested review from kylehuntsman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willscott @codecov-commenter @hannahhoward