Add the ability to override default IPNI endpoint #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 71.10% 70.83% -0.27%
==========================================
Files 68 68
Lines 6063 6079 +16
==========================================
- Hits 4311 4306 -5
- Misses 1507 1528 +21
Partials 245 245
|
kylehuntsman
approved these changes
May 12, 2023
`lassie fetch` was hard-coded to always use `cid.contact`. The changes introduce a new flag `--ipniEndpoint` to allow overriding the default endpoint used to discover content providers. This feature is useful when debugging a local indexer instance or an explicit IPNI instance for content discovery/retrieval.
masih
force-pushed
the
masih/ipni_endpoint_flag
branch
from
fd6cdd4 to
ad7b5e8
Compare
|
Thank you for the review @kylehuntsman 🙌 |
davidd8
reviewed
May 12, 2023
| lassieOpts = append(lassieOpts, finderOpt) | ||
| } else if cctx.IsSet("ipniEndpoint") { |
There was a problem hiding this comment.
Can we add some unit tests for this new cmd flag?
There was a problem hiding this comment.
we currently don't have tests that go down in to the cli, unfortunately, we mostly do integration tests through the daemon so most of the code in here isn't touched
There was a problem hiding this comment.
We can use a similar setup as go-car script test for lassie CLI
rvagg
added a commit
that referenced
this pull request
May 15, 2023
rvagg
added a commit
that referenced
this pull request
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lassie fetchwas hard-coded to always usecid.contact. The changes introduce a new flag--ipniEndpointto allow overriding the default endpoint used to discover content providers.This feature is useful when debugging a local indexer instance or an explicit IPNI instance for content discovery/retrieval.