Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty string env vars when we parse CLI flags #208

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

kylehuntsman
Copy link
Contributor

Ignores CLI flags that require parsing the flag value when the value of the flag is an empty string. This prevents environment variables that default to empty strings in build systems from erroring out when the empty string value is parsed as though it was a user provided value, as mentioned in #191.

Closes #191

@kylehuntsman kylehuntsman requested review from willscott and rvagg April 27, 2023 21:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #208 (65a61e7) into main (c2f36c3) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   70.50%   70.33%   -0.18%     
==========================================
  Files          62       62              
  Lines        5262     5272      +10     
==========================================
- Hits         3710     3708       -2     
- Misses       1349     1361      +12     
  Partials      203      203              
Impacted Files Coverage Δ
cmd/lassie/fetch.go 0.00% <0.00%> (ø)
cmd/lassie/flags.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@rvagg rvagg merged commit 7979b59 into main Apr 28, 2023
@rvagg rvagg deleted the fix/empty-env-vars branch April 28, 2023 04:24
rvagg added a commit that referenced this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle env var with empty string
3 participants