Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't over-ride log levels when set by environment #205

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

willscott
Copy link
Contributor

No description provided.

@willscott willscott requested a review from rvagg April 26, 2023 14:27
@codecov-commenter
Copy link

Codecov Report

Merging #205 (3cb22c7) into main (fb7dc2e) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   70.49%   70.44%   -0.06%     
==========================================
  Files          62       62              
  Lines        5261     5262       +1     
==========================================
- Hits         3709     3707       -2     
  Misses       1351     1351              
- Partials      201      204       +3     
Impacted Files Coverage Δ
cmd/lassie/main.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@kylehuntsman kylehuntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep the setting of the log level across subsystems even if an environment variable is provided. I've suggested a change above.

Copy link
Contributor

@kylehuntsman kylehuntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unaware that GOLOG_LOG_LEVEL could be used to also specify log levels for subsystems. Thanks @willscott 👍. With that in mind, it makes sense for the GOLOG_LOG_LEVEL environment variable to override any defaults and log level flags.

@willscott willscott merged commit c2f36c3 into main Apr 27, 2023
@willscott willscott deleted the feat/log-env branch April 27, 2023 06:45
rvagg added a commit that referenced this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants