Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outstanding bugs in aggregate event recorder #202

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

hannahhoward
Copy link
Collaborator

Goals

Finish off end to end aggregate events. Requires filecoin-project/lassie-event-recorder#36

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Merging #202 (e5b78d8) into main (8b1af64) will decrease coverage by 0.01%.
The diff coverage is 82.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   70.41%   70.41%   -0.01%     
==========================================
  Files          62       62              
  Lines        5229     5232       +3     
==========================================
+ Hits         3682     3684       +2     
  Misses       1348     1348              
- Partials      199      200       +1     
Impacted Files Coverage Δ
cmd/lassie/main.go 0.00% <0.00%> (ø)
...g/aggregateeventrecorder/aggregateeventrecorder.go 89.20% <86.84%> (-1.55%) ⬇️

... and 3 files with indirect coverage changes

@willscott willscott merged commit fb7dc2e into main Apr 25, 2023
@willscott willscott deleted the feat/fix-aggregated-event-issues branch April 25, 2023 06:33
rvagg added a commit that referenced this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants