Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI UX: --provider enhancements for more convenient SP descriptions #418

Closed
rvagg opened this issue Sep 13, 2023 · 0 comments
Closed

CLI UX: --provider enhancements for more convenient SP descriptions #418

rvagg opened this issue Sep 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@rvagg
Copy link
Member

rvagg commented Sep 13, 2023

--provider should accept:

  • http multiaddrs shouldn't require peer ID, they don't get used or validated in any way (yet); figure out how to propagate a non-peer ID through the system, perhaps fake it like we have to with Bitswap in some places.
  • http://... and https://... and convert to http multiaddrs, although we'll need to do something about peer ID (see above).
  • If the input is recognisably a miner ID (is /f\d+/ enough for that?), look it up on heyfil to see if we can determine addresses for it, e.g. https://heyfil.prod.cid.contact/sp/f0127896
  • If the input string can be passed through peer.Decode() then look it up on heyfil to see if it has a miner id, e.g. https://heyfil.prod.cid.contact/sp?peerid=12D3KooWE8yt84RVwW3sFcd6WMjbUdWrZer2YtT4dmtj3dHdahSZ, then do the above to find addresses for it
@rvagg rvagg added the enhancement New feature or request label Sep 13, 2023
rvagg added a commit that referenced this issue Sep 29, 2023
Where peer ID is not provided, we generate a random one for internal use.

Ref: #418
rvagg added a commit that referenced this issue Oct 2, 2023
Where peer ID is not provided, we generate a random one for internal use.

Ref: #418
@rvagg rvagg closed this as completed in efaf293 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant