replace SimpleQaPower with flags #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LesnyRumcajs
force-pushed
the
replace-qa-power-with-flags-miner
branch
from
bbd32e3
to
dd56b95
Compare
ZenGround0
approved these changes
Sep 1, 2023
LesnyRumcajs
force-pushed
the
replace-qa-power-with-flags-miner
branch
from
d2aa21d
to
e3b5c01
Compare
|
Hm, should the type of the flag be aligned with the type in bultin actors? I.e., both either 32 or 64 bits? |
I gave it a try and cbor gen does not work with int32s. This should be fine for the long foreseeable future until with have 31 new flags. I'll file an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See filecoin-project/builtin-actors#1275
and filecoin-project/builtin-actors#1395 (most notably @ZenGround0 comment)
In short, we want to have an easily extensible flags field for the SectorOnChainInfo instead of a field per flag, which is wasteful.